Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "404 not found" pages on the documentation #2951

Closed
astrojuanlu opened this issue Aug 18, 2023 · 11 comments
Closed

Improve "404 not found" pages on the documentation #2951

astrojuanlu opened this issue Aug 18, 2023 · 11 comments
Assignees
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Feature Request New feature or improvement to existing feature

Comments

@astrojuanlu
Copy link
Member

Description

#2486 fixed #2464, and the current situation is much better than what we had.

However, navigating to old versions of the docs is hard: readthedocs/readthedocs.org#10643

It would be better if 404 pages reflected the navigation structure of each version.

Context

Used very often by @stichbury and the rest of the team to see how a specific page used to look.

Possible Implementation

I think there's an undocumented feature of Sphinx in that one can add a 404.md page to the docs (if it's documented, I haven't found it). That should be a solution going forward.

For older versions, it's more complicated. We could create a branch in the repository for each version we want to amend (not necessarily all of them) that adds such a page.

Apart from all this, we should probably keep the sphinx-notfound-page extension for the time being.

Possible Alternatives

@astrojuanlu astrojuanlu added the Issue: Feature Request New feature or improvement to existing feature label Aug 18, 2023
@astrojuanlu
Copy link
Member Author

@stichbury
Copy link
Contributor

@astrojuanlu Given the discussion in #2980 should we now focus our attention on branches for adding 404 pages just for v 0.17.7 and for 0.18.0 onwards (with possible omission of 0.18.0-0.18.4 as they're not indexed)?

@astrojuanlu
Copy link
Member Author

Indeed, we can do a proof of concept with 0.17.7, and if it works extend it to 0.18.5 onwards.

For now, let's add a 404 page in the main branch, so it works with latest and soon stable too.

@astrojuanlu
Copy link
Member Author

Is it possible to do a "did you mean?" page on 404 which offers URLs suggestions? This is my biggest gripe doing user support as I search for page which no longer exists on a newer version.

_Originally posted by @datajoely in kedro-org/kedro-sphinx-theme#5

@astrojuanlu
Copy link
Member Author

astrojuanlu commented Dec 18, 2023

Missing:

  • 1. Examples of this happening in the wild
  • 2. A better definition of the outcome

@astrojuanlu
Copy link
Member Author

cc @stichbury could you help me with (1)? and I'll describe (2) in a bit more detail

@stichbury stichbury added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Dec 19, 2023
@stichbury
Copy link
Contributor

Some ideas for examples in the wild:

  1. This is quite nice because it brings up an explanation and a search box, prepopulated with the URL you tried to find, and the results of that search for you to choose from:
image

(results from https://ably.com/docs/general/push/publis?q=dafd)


  1. Basic search bar (not populated) to help move people onwards
image
  1. From ARM developer docs
image
  1. This is very basic but gives a contact (we could push people at Slack)
image

@astrojuanlu
Copy link
Member Author

@astrojuanlu
Copy link
Member Author

I initially described the problematic navigation in readthedocs/readthedocs.org#10643 (comment), but with the new add-ons, the logic has changed: readthedocs/addons#223

As a result, now it's impossible to land in a 404 page when switching versions. The downside though is that navigating across versions is more difficult now.

@stichbury stichbury self-assigned this Jan 12, 2024
@stichbury
Copy link
Contributor

Looking at this again and I'm not convinced there's anything more we can do. Would adding a 404.md page have any advantages over the current situation of using the extension, given the add-ons have changed the logic of this situation? I'm happy to try it if so, otherwise let's close this.

@astrojuanlu
Copy link
Member Author

Indeed, I think there's not much for us to do here until we have more clarity on readthedocs/addons#211. Closing for now.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation Issue: Feature Request New feature or improvement to existing feature
Projects
Archived in project
Development

No branches or pull requests

2 participants