-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of GitHub magic in README [Quick Win] #3416
Comments
Moving this to Viz as it'll be part of design initially and quite likely require web savvy too. |
@SajidAlamQB also reported this issue on pypi - https://pypi.org/project/kedro/ |
We don't need tech design for this. We need to just do it. |
I encountered this when publishing github action. The way we do conditional images is deprecated. This link should help. |
@ravi-kumar-pilla could you check if the |
@astrojuanlu I see an open ticket - pypi/warehouse#11251 . Needs some more searching/testing when we work on the ticket. I tried testing the html and |
The way to test this would be to upload a test version to https://test.pypi.org/project/kedro/ or a newly registered package only for testing purposes. |
We tried to replicate this issue and it doesn't exist anymore for Readme anymore. It does exist for Pypi which we will work on fixing. |
@marrrcin reported that he saw the README like this
and it's because of a bad combination of the magic we're using to detect light/dark theme
kedro/README.md
Lines 1 to 2 in 8257d55
and how GitHub assumes night = dark
This has created other problems in the past #2961 (comment)
Given that this is broken on PyPI and half-broken on GitHub, I'd say let's get rid of this.
A strawman proposal would be something like
But better to have this properly designed.
The text was updated successfully, but these errors were encountered: