Get rid of GitHub magic in README [Quick Win]

[astrojuanlu]

@marrrcin reported that he saw the README like this

and it's because of a bad combination of the magic we're using to detect light/dark theme

kedro/README.md

Lines 1 to 2 in 8257d55

	
	

and how GitHub assumes night = dark

This has created other problems in the past #2961 (comment)

Given that this is broken on PyPI and half-broken on GitHub, I'd say let's get rid of this.

A strawman proposal would be something like

But better to have this properly designed.

[stichbury]

Moving this to Viz as it'll be part of design initially and quite likely require web savvy too.

[rashidakanchwala]

@SajidAlamQB also reported this issue on pypi - https://pypi.org/project/kedro/

[astrojuanlu]

We don't need tech design for this. We need to just do it.

[ravi-kumar-pilla]

I encountered this when publishing github action. The way we do conditional images is deprecated. This link should help.

[astrojuanlu]

@ravi-kumar-pilla could you check if the <picture> thing is rendered correctly on PyPI?

[ravi-kumar-pilla]

@ravi-kumar-pilla could you check if the <picture> thing is rendered correctly on PyPI?

@astrojuanlu I see an open ticket - pypi/warehouse#11251 . Needs some more searching/testing when we work on the ticket.

I tried testing the html and picture tag seems to work fine -

[astrojuanlu]

The way to test this would be to upload a test version to https://test.pypi.org/project/kedro/ or a newly registered package only for testing purposes.

[rashidakanchwala]

We tried to replicate this issue and it doesn't exist anymore for Readme anymore. It does exist for Pypi which we will work on fixing.