Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2628] Confusing error message if number of node inputs/outputs dont match defintion in node.py #761

Closed
lucasjamar opened this issue May 5, 2021 · 5 comments
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed

Comments

@lucasjamar
Copy link
Contributor

Description

I am using kedro 0.17.3 and I noticed that having more or fewer inputs or outputs in a node than what is defined in pipeline.py throws this rather confusing error message.
(I am using conda 4.9.2, python 3.8 and windows 10)

image

In kedro<=0.16.6, the error message was clearer and one could easily pinpoint what needed to change:

image

Context

This issue could be related to similar issues users have been having with this error message:

  1. https://stackoverflow.com/questions/66751310/kedro-failed-to-find-the-pipeline-named-default/67400956#67400956
  2. Default and Custom Pipeline not being registered and cannot be found. #731 (comment)
  3. https://discourse.kedro.community/t/failed-to-find-the-pipeline-named-default/438

Steps to Reproduce

  1. pip install kedro>=0.17.0
  2. kedro new --starter=pandas-iris
  3. Remove or duplicate one of the inputs/ ouputs in one of the pipeline.py files.
@lucasjamar lucasjamar added the Issue: Bug Report 🐞 Bug that needs to be fixed label May 5, 2021
@antonymilne
Copy link
Contributor

Thanks for the bug report! This does indeed look like the same issue that we were having before and thought we had fixed in 0.17.3 😕

@lorenabalan I think you pointed out before that there was still a bug to do with this. Is it the same as the one reported? Do we already have a ticket for it?

@lorenabalan
Copy link
Contributor

No, that was related to upgrading kedro version in place vs moving code to new environment with latest kedro version installed. This should be filed under a new ticket.

@antonymilne antonymilne changed the title Confusing error message if number of node inputs/outputs dont match defintion in node.py [KED-2628] Confusing error message if number of node inputs/outputs dont match defintion in node.py May 11, 2021
@antonymilne
Copy link
Contributor

antonymilne commented May 11, 2021

@lucasjamar Trying this out myself, I think the node validation error message is actually still being shown, just it's further up the stack trace. This is indeed confusing though, so I've filed a ticket to try and fix it and make the clearer error message appear last.

@lucasjamar
Copy link
Contributor Author

Very much appreciated @AntonyMilneQB :)

@antonymilne
Copy link
Contributor

antonymilne commented Jun 4, 2021

This is solved in 9e87ffb, so will be part of 0.17.4. Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐞 Bug that needs to be fixed
Projects
None yet
Development

No branches or pull requests

3 participants