Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to try different credentials when saving entry on all SPAs #229

Open
luckyrat opened this issue Apr 15, 2019 · 1 comment
Open

Comments

@luckyrat
Copy link
Member

Single Page Applications that do not create a new form after a failed sign-in attempt will lose their submit listener so further attempts by the user to type and then save their correct credentials will only work if they refresh the page between each failed attempt.

Not sure what we can do about this without risking leaving listeners lying around taking up memory.

Maybe some sort of timeout could help? If the submit button still exists after a second we can reattach? Seems flaky. Needs detailed planning. Ideas welcome.

@luckyrat
Copy link
Member Author

Firefox's solution might be worth investigation, although whether it is possible to replicate that approach from within a webextension is doubtful: https://bugzilla.mozilla.org/show_bug.cgi?id=1166995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant