Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store KeePassRPC data in CustomData instead of an advanced string #24

Open
1 of 5 tasks
luckyrat opened this issue Apr 16, 2018 · 2 comments
Open
1 of 5 tasks

Store KeePassRPC data in CustomData instead of an advanced string #24

luckyrat opened this issue Apr 16, 2018 · 2 comments
Assignees
Milestone

Comments

@luckyrat
Copy link
Member

luckyrat commented Apr 16, 2018

KeePass 2.35 introduced a neater way to store our plugin custom data. This necessitates the use of the kdbx4 file format.

  • Wait for a new KeePass release to indicate broad support for the kdbx4 format among major KeePass ports.
  • Bump minimum supported KeePass version to 2.35.
  • Implement a new KeePassRPC feature to migrate all custom data to the new format and delete the old advanced strings.
  • Trigger this feature automatically if the database is saved into kdbx4 format by KeePass.
  • (optional): Allow user to trigger the feature manually if they are running a version of KeePass > 2.35 but lower than the hypothetical version that forces saving into kdbx4 format.
@luckyrat
Copy link
Member Author

luckyrat commented Aug 4, 2023

I've not seen anything to say that kdbx4 is now widely supported by KeePass 2 ports. So perhaps we should adjust the plan to avoid the automatic triggering of the migration but instead have a feature setting of whether to use the CustomData or Advanced String. We could default to CustomData for new databases (or databases with no KeePassRPC configuration already present) but otherwise only change the storage location for existing and new entries if the user makes a change to the setting.

Still, if there is a high chance that many new users will have to change this setting after experiencing cross-application data loss we might want to wait even longer than we already have.

@luckyrat
Copy link
Member Author

We'll enforce this new storage location in KeePassRPC v2. There won't be any opt-out but we will keep the old string configuration around for at least a while, to make rollback even easier if anyone finds they have to stay on the older KeePassRPC version for a short time while compatibility issues are addressed. See also #143

@luckyrat luckyrat self-assigned this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant