Fix missing context bug in VaultLoader listener #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is a specific instance of a more general fault where context could be lost during async operations. This case was noticed because the recently added code to store and flush data to shared storage takes long enough that Flutter has an increased chance to destroy the old context and this actually happened on some devices. I've investigated other instances of this problem and either developed a more defensive algorithm or commented when it is uncertain whether the problem is applicable or not.
luckyrat
deleted the
fix/missing-context-after-ui-delay-or-bloc-listener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is a specific instance of a more general fault where context could be
lost during async operations. This case was noticed because the recently
added code to store and flush data to shared storage takes long enough
that Flutter has an increased chance to destroy the old context and this
actually happened on some devices. I've investigated other instances
of this problem and either developed a more defensive algorithm or
commented when it is uncertain whether the problem is applicable or not.