Adding handler support for HTML entities. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keedi
added a commit
that referenced
this pull request
Dec 12, 2013
Adding handler support for HTML entities.
|
++@jmacdotorg |
|
Just released v0.004. Thanks! |
|
Welcome... thanks for writing this script. Made good use of it this week, and was happy that it existed! N.B.: I have an open pull request on houseabsolute/Markdent#1 that fixes another bug involving list numbering; will open another PR here (with a Markdent required-version bump) if and when that other PR gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, markdown2pod crashes if it encounters an HTML entity such as
&or<in the source text. This is because its handler does not define thehtml_entitymethod that Markdent::Role::EventsAsMethods expects.This patch provides this method, transforming the given HTML entity into a POD
E<...>entity. It also provides a trivial test for it.