Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts: Name conflict with vue 2.5.17 #18

Closed
falue opened this issue Sep 28, 2018 · 1 comment
Closed

Shortcuts: Name conflict with vue 2.5.17 #18

falue opened this issue Sep 28, 2018 · 1 comment

Comments

@falue
Copy link

falue commented Sep 28, 2018

With maybe the latest release of vue 2.5.17 there seems to be some conflicts due to the shortcuts named 'success' and 'error' – same as the methods in vue.
Vue thows these errors for each v-input:

[Vue warn]: Method "success" has already been defined as a prop.
[Vue warn]: Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders. Instead, use a data or computed property based on the prop's value. Prop being mutated: "success"

Only way around seems to be to set createShortcuts: false in main.js which works as expected:

Vue.use(VueFlashMessage,
  {
    messageOptions: {
      timeout: 3000,
      ...
    },
    template,
    createShortcuts: false  }
);

Thanks!

@keen-on-design
Copy link
Owner

Fixed in 0.7.0. Methods were renamed to flashSuccess etc. Please upgrade and enjoy!:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants