Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Providing a config file on the command-line #95

Closed
Shadowfiend opened this issue Apr 30, 2018 · 5 comments · Fixed by #146
Closed

Providing a config file on the command-line #95

Shadowfiend opened this issue Apr 30, 2018 · 5 comments · Fixed by #146
Assignees
@Shadowfiend
Labels
💻 interface The user interface: command-line invocation, packaging, etc.
Projects
Go Threshold Relay Milestone 1

Comments

@Shadowfiend
Copy link
Contributor

Shadowfiend commented Apr 30, 2018 •
edited

Just a --config flag that can let us start feeding a config file into the system. It should route the config file through the new readConfig function.

See #52 for more, though this is quite literally just a flag that takes a path :)
@Shadowfiend Shadowfiend added the 💻 interface The user interface: command-line invocation, packaging, etc. label Apr 30, 2018
@Shadowfiend Shadowfiend self-assigned this Apr 30, 2018
@Shadowfiend
Copy link
Contributor Author

Passing this on to you @l3x since I haven't been able to kick it off.

@l3x
Copy link
Contributor

l3x commented May 22, 2018

I'm on it...

@Shadowfiend
Copy link
Contributor Author

Just to clarify, process-wise---this should be a separate PR from #118, we should close 118 out first, and let's make sure to move this to In Progress on the project board when you start work on this one :)

@l3x l3x moved this from In Design to In Progress in Go Threshold Relay Milestone 1 May 23, 2018
@l3x l3x mentioned this issue May 25, 2018
Closed
@Shadowfiend Shadowfiend mentioned this issue Jun 4, 2018
Open
@l3x
Copy link
Contributor

l3x commented Jun 7, 2018 •
edited

This PR is ready for another review.

I made the following updates:

  • f4fd2d8 (HEAD -> add-config-flag, origin/add-config-flag) Add smoke-test command
  • c00b81b Add tests for config flag
  • d723c4e Remove cli package
  • 03aa5b8 Add get-info command to display basic keep client info
  • d434688 Pass Version and Revision to NewApp func
  • 77f80f8 Update Gopkg.toml to prevent warnings.
  • b04d9a0 Create cmd package and move config package into it
  • 6efa66b Merge remote-tracking branch 'origin/master' into add-config-flag

Note: The tests don't depend on the keep-client binary to be present on CircleCi.

@Shadowfiend
Copy link
Contributor Author

No need to note PR updates in the issue, a ping in the PR is enough. The commits since the last discussion are visible there too :)

@l3x l3x mentioned this issue Jun 9, 2018
Merged
Go Threshold Relay Milestone 1 automation moved this from In Progress to Done Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shadowfiend Shadowfiend

Labels
💻 interface The user interface: command-line invocation, packaging, etc.
Projects
No open projects
Go Threshold Relay Milestone 1
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add config flag keep-network/keep-core
Add config flag keep-network/keep-core
2 participants
@Shadowfiend @l3x