Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Consistent use of SafeERC20 for external tokens #272

Closed
pdyraga opened this issue Mar 3, 2020 · 0 comments · Fixed by #275
Closed

Consistent use of SafeERC20 for external tokens #272

pdyraga opened this issue Mar 3, 2020 · 0 comments · Fixed by #275
Assignees
@nkuba
Labels
👊 attack Possible attacks that may need investigation. ⛓chain
Milestone
v0.9.0

Comments

@pdyraga
Copy link
Member

pdyraga commented Mar 3, 2020

Use SafeERC20 features to interact with potentially broken tokens used in the system. E.g. TokenGrant.receiveApproval() in keep-core is using safeTransferFrom while contracts such as BondedECDSAKeep are not. This issue aims at inspecting the code and making sure all direct token calls are replaced with SafeERC20 features.
@pdyraga pdyraga added this to the v0.10.0 milestone Mar 3, 2020
@pdyraga pdyraga added the 👊 attack Possible attacks that may need investigation. label Mar 3, 2020
@nkuba nkuba mentioned this issue Mar 4, 2020
Merged
@pdyraga pdyraga modified the milestones: v0.10.0, v0.9.0 Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nkuba nkuba

Labels
👊 attack Possible attacks that may need investigation. ⛓chain
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Use safe transfers for ERC20 tokens keep-network/keep-ecdsa
2 participants
@pdyraga @nkuba