Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allowing fixed point math with arbitrary denominators #314

Open
FredCoen opened this issue Jun 11, 2024 · 1 comment
Open

feat: Allowing fixed point math with arbitrary denominators #314

FredCoen opened this issue Jun 11, 2024 · 1 comment
Labels
enhancement Enhancement of the code, not introducing new features. stale No activity for quite some time.

Comments

@FredCoen
Copy link

FredCoen commented Jun 11, 2024

Right now wad_ray_math only offers math operations with denominators being WAD or RAY. This does not allow math between WAD and RAY but only WAD to WAD and RAY to RAY. It would be great to be able to specify a "denominator" (scale of the parameter you want to multiply or divide by) for more flexibility like it is done in this very popular solidity library https://github.com/transmissions11/solmate/blob/main/src/utils/FixedPointMathLib.sol#L36

would it make sense to port this library here?

Thanks,
I'd be happy to do it!

@FredCoen FredCoen added the enhancement Enhancement of the code, not introducing new features. label Jun 11, 2024
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale No activity for quite some time. label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features. stale No activity for quite some time.
Projects
None yet
Development

No branches or pull requests

1 participant