New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify tx version on execute #162
Verify tx version on execute #162
Conversation
Hey @abdelhamidbakhta 👋 This should be ready to be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
5f18555
to
489226c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hey @zediogoviana, could you add one test within |
Hey @EvolveArt, I can do that, no problem. However, I'm not understanding how the nonce verification test impacts this PR. Just checking if you aren't referring to PR #129 instead. |
Sorry I meant tx version you're right, got confused between PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
The current
execute
method doesn't check if the transaction version being passed is valid or not.Transaction.version
uses aU256
as the type.Issue Number: #127
What is the new behavior?
This PR adds a transaction version validation similar to what happens in the blockifier.
It also replaces the usage of
U256
for the version type in theTransaction
struct to be anu8
, as specified in the issue.Existing tests were updated, and new ones were added.
Does this introduce a breaking change?
Other information