New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RPC - add starknet_getClassHashAt
#276
feat: RPC - add starknet_getClassHashAt
#276
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 35.66% 35.33% -0.33%
==========================================
Files 61 61
Lines 5050 5097 +47
Branches 5050 5097 +47
==========================================
Hits 1801 1801
- Misses 2779 2826 +47
Partials 470 470
☔ View full report in Codecov by Sentry. |
7948acc
to
a2b1d3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left few comments, please improve integration tests (add more cases and test return values)
Thanks for the review @EvolveArt , will update accordingly ✌️ |
5ce375d
to
04075ff
Compare
6967432
to
04bec2f
Compare
hey @ftupas what is the status of this PR ? |
Hi @abdelhamidbakhta, it's up for review normally I've resolved the conflicts 🤙 I've also improved the integration test by adding more test cases |
awesome thanks for the prompt reply. I will leave @EvolveArt continue the review then |
04bec2f
to
b2dcc51
Compare
b2dcc51
to
3e9eda3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This item belongs to payment request #19FC5A on OnlyDust:
|
Implement
starknet_getClassHashAt
RPC that gets the contract class hash in the given block for the contract deployed at the given addressPull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #196
What is the new behavior?
getClassHashAt
to RPC clientgetClassHashAt
RPC methodDoes this introduce a breaking change?
Other information