Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucas/state reader #283

Merged
merged 12 commits into from Apr 24, 2023
Merged

Conversation

LucasLvy
Copy link
Contributor

@LucasLvy LucasLvy commented Apr 21, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number:

What is the new behavior?

  • We don't copy the whole substrate state in a blockifier type anymore

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 87.36% and project coverage change: +0.17 🎉

Comparison is base (5deb543) 44.40% compared to head (6babca3) 44.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   44.40%   44.57%   +0.17%     
==========================================
  Files          57       57              
  Lines        4630     4639       +9     
==========================================
+ Hits         2056     2068      +12     
+ Misses       2574     2571       -3     
Impacted Files Coverage Δ
crates/primitives/starknet/src/execution/mod.rs 52.66% <33.33%> (+4.00%) ⬆️
crates/pallets/starknet/src/mock.rs 60.00% <66.66%> (-0.27%) ⬇️
crates/pallets/starknet/src/lib.rs 63.58% <72.97%> (-3.03%) ⬇️
crates/pallets/starknet/src/tests.rs 100.00% <100.00%> (ø)
crates/primitives/starknet/src/transaction/mod.rs 87.68% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LucasLvy LucasLvy requested a review from EvolveArt April 21, 2023 16:19
@LucasLvy LucasLvy marked this pull request as ready for review April 21, 2023 16:20
Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments

crates/pallets/starknet/src/tests.rs Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/lib.rs Show resolved Hide resolved
Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LucasLvy LucasLvy merged commit 1fddae2 into keep-starknet-strange:main Apr 24, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants