Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: impl get_state_updates using re_execute_transactions #1594

Closed
tdelabro opened this issue May 6, 2024 · 2 comments · Fixed by #1602
Closed

dev: impl get_state_updates using re_execute_transactions #1594

tdelabro opened this issue May 6, 2024 · 2 comments · Fixed by #1602
Assignees
Labels
enhancement New feature or request

Comments

@tdelabro
Copy link
Collaborator

tdelabro commented May 6, 2024

What is the problem?

State updates used to be stored directly onto the disk for each block.
They are not anymore since #1580, meaning the RPC won't work anymore.

What to do?

Replace the current implementation with a call to re_execute_transactions adding the option to have the StateDiff.
Execute all the tx on the same CachedState, and at the end, return the StateDiff

Remove state_diff and get_state_diff and cairo_job and update_cairo_job from crates/client/db/src/da_db.rs. I think we should keep the last_proved_block logic for now.

@tdelabro tdelabro added the enhancement New feature or request label May 6, 2024
@tonypony220
Copy link
Contributor

hi! what to try this, if it's not asap

@tdelabro
Copy link
Collaborator Author

tdelabro commented May 6, 2024

@tonypony220 assigned to you!
Do you have an ETA in mind?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants