Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create get_snos_input(block_id: BlockId) -> Resutl<SnosInput,_> rpc route #1595

Open
tdelabro opened this issue May 6, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@tdelabro
Copy link
Collaborator

tdelabro commented May 6, 2024

Feature Request

The prover will need to be able to data out of the chain for each block it want to prove.
To allow this, we will add a custom RPC get_snos_input that return the Input datastruct expected by SNOS.

Describe Preferred Solution

Add the rpc route in crates/client/rpc-core/src/lib.rs to the MadaraRpcApi trait.
Implement it in crate/client.

Related Code
Here is the SnosInput struct
https://github.com/keep-starknet-strange/snos/blob/01ed09975cb8b0cdb878f569fe2f8aac5c9e9a7a/src/io/input.rs#L18
Import it from this crate

@tdelabro tdelabro added the enhancement New feature or request label May 6, 2024
@0xSpyC
Copy link

0xSpyC commented May 7, 2024

Hello, can i pick this one ? @tdelabro

@tdelabro
Copy link
Collaborator Author

sure. It is not an easy one tho. Don't hesitate to ask for help on our telegram channel

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 13, 2024
@tdelabro
Copy link
Collaborator Author

@0xSpyC are you still working on this? It has been two weeks?

@0xSpyC
Copy link

0xSpyC commented Jun 14, 2024

Yes, I'm still on it, sorry for the delay, it took me a while to figure out how the commitment fact is computed, I'll do my best to deliver it quickly from now on. Is there anyone who has mastered the low-level state so they can tell me if my understanding is correct?

@tdelabro
Copy link
Collaborator Author

Sure, push your code in a draft PR and add your question there

@github-actions github-actions bot removed the stale label Jun 15, 2024
@ocdbytes
Copy link
Contributor

Hey @0xSpyC

Are you still working on it ? If not I can take it up. As we are currently integrating the SNOS job in madara orchestrator we need this component.

@apoorvsadana
Copy link
Collaborator

@0xSpyC I am assigning this to @ocdbytes, let me know in case you've made any progress.

@0xSpyC
Copy link

0xSpyC commented Jun 20, 2024

Hey @0xSpyC

Are you still working on it ? If not I can take it up. As we are currently integrating the SNOS job in madara orchestrator we need this component.

It's ok i understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants