Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTP generation does not handle 3 settings (TrayTOTP 'time sync') #28

Closed
nta opened this issue Jul 19, 2019 · 1 comment
Closed

TOTP generation does not handle 3 settings (TrayTOTP 'time sync') #28

nta opened this issue Jul 19, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@nta
Copy link

nta commented Jul 19, 2019

TrayTOTP for KeePass (.NET) on desktop systems might sometimes store formats such as 30;6;https://www.google.com/ in TOTP Settings, with the intent to use the Date header from a HTTP query as a source for a time delta. Currently, in KeePassium, these entries seem to be skipped entirely, and treated as if there's no TOTP.

guard settings.count == 2 else {
Diag.warning("Unexpected TOTP settings number [expected: 2, got: \(settings.count)]")
return nil
}

Keepass2Android, for example, does not implement this, but shows a warning instead when viewing one of these entries notifying the user that, indeed, time correction is not implemented:

https://github.com/PhilippC/keepass2android/blob/ee6b7c4fe0257af35eed0eed09c83721db72e94c/src/keepass2android/Totp/TrayTotpPluginAdapter.cs#L147-L148

@keepassium
Copy link
Owner

I'll get this fixed, thanks!

It is tempting to implement this properly, with actual network requests. However, I am not sure whether arbitrary network requests would be an acceptable behavior for KeePassium... Will probably just ignore the URL parameter for now...

@keepassium keepassium added the bug Something isn't working label Jul 19, 2019
@keepassium keepassium self-assigned this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants