Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push binaries to downstream distros #5

Closed
droidmonkey opened this issue Sep 30, 2016 · 59 comments
Closed

Push binaries to downstream distros #5

droidmonkey opened this issue Sep 30, 2016 · 59 comments

Comments

@droidmonkey
Copy link
Member

Need to figure out the process for overtaking binary distribution for keepassx on upstream. May start with a ppa or similar.

@nutritiousreject
Copy link

https://wiki.archlinux.org/index.php/creating_packages#Creating_a_PKGBUILD

Not looking to maintain this packages repo, But submitting packages to the AUR is pretty easy

@zokier
Copy link

zokier commented Sep 30, 2016

For Arch Linux specifically, there are already several versions of keepassx on AUR based on various github forks. Best option in my opinion would be to merge those forks and then attempt to enlist the maintainers to join forces in packaging.

@Mte90
Copy link

Mte90 commented Sep 30, 2016

Will be amazing in debian https://packages.qa.debian.org/k/keepassx.html

@phoerious
Copy link
Member

If nobody else volunteers, I would take responsibility for the AUR package, but if someone else wants to do it, I'd be glad. I'm always open for supporting in this regard, though.

@daniellandau
Copy link
Contributor

daniellandau commented Oct 1, 2016

I went ahead and made the AUR package: https://aur.archlinux.org/packages/keepassx-reboot-git/

I started maintaining my personal fork a while back when I couldn't get my trivial usability fix merged (or commented on or acknowledged in any way) upstream. I also rebased a couple of pull requests by others, I'll send them too as pull requests here.

@Gerii
Copy link

Gerii commented Oct 2, 2016

A PPA would be nice for Ubuntu users. Has anyone experience with maintaining one?

@droidmonkey
Copy link
Member Author

I created a PPA, great idea!

https://launchpad.net/~droidmonkey/+archive/ubuntu/keepassx-reboot

@Gerii
Copy link

Gerii commented Oct 2, 2016

Nice, thanks!

@droidmonkey droidmonkey added this to the v2.1.0 milestone Oct 2, 2016
@george-viaud
Copy link

PPA for source files or binaries? I strongly advise against using a piece of open source security software pre-compiled from a PPA.

Would be better to get it from source and build yourself - otherwise too much funny stuff can be done in the binary and nobody would know.

"Trust but Verify"

On 10/02/2016 07:27 AM, Gerald P. wrote:

A PPA would be nice for Ubuntu users. Has anyone experience with maintaining one?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #5 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/APzGhvJ826wVStoTJVKgparoVdeVn5-Sks5qv783gaJpZM4KK_b4.

@phoerious
Copy link
Member

The binary could be signed with some "official" GPG key whose public key is pushed to the source Git repository.

@droidmonkey
Copy link
Member Author

Agree with @george-viaud I am very security conscious. Any push from the ppa will be signed with the GPG I used to register with launchpad. Public keys/fingerprints should be posted to the README or SECURITY files for future use in validation.

Seem reasonable?

@george-viaud
Copy link

It helps but there is no way to guarantee the bins themselves were not intentionally or inadvertantly compromised. Dane with the keys if they became compromised, no? Compiling from sources which are publicly scrutinised is really the best we have.

Perhaps focus on making the build process as turn key as possible, and then from within the repo itself? Perhaps a .sh or similar?

Just my 2 cents of course.


From: Jonathan notifications@github.com
Sent: Oct 2, 2016 10:32 AM
To: keepassxreboot/keepassx
Cc: George Viaud; Mention
Subject: Re: [keepassxreboot/keepassx] Push new binaries to upstream distros (#5)

Agree with @george-viaudhttps://github.com/george-viaud I am very security conscious. Any push from the ppa will be signed with the GPG I used to register with launchpad. Public keys/fingerprints should be posted to the README or SECURITY files for future use in validation.

Seem reasonable?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/5#issuecomment-250983536, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APzGhqsWhJSpOh1qF_clLcr64ig-VLqKks5qv-rDgaJpZM4KK_b4.

@george-viaud
Copy link

That just guarantees that the binary posted matches the one references by the hash. Not that it was compiled from the untainted source.


From: Janek Bevendorff notifications@github.com
Sent: Oct 2, 2016 10:18 AM
To: keepassxreboot/keepassx
Cc: George Viaud; Comment
Subject: Re: [keepassxreboot/keepassx] Push new binaries to upstream distros (#5)

The binary could be signed with some "official" GPG key whose public key is pushed to the source Git repository.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com//issues/5#issuecomment-250982759, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APzGhswQFgepA4C1o25ZJepstQ39bEctks5qv-dWgaJpZM4KK_b4.

@timeraider4u
Copy link

timeraider4u commented Oct 2, 2016

@george-viaud: Yes, compiling from source (like in Gentoo Linux) leads to an increase in trust. But normal end-users will not want to compile anything from source at all. They just want to use their favourite password-manager like they would do on Windows by installing a binary package. But I think with Debian/Ubuntu systems it is possible to create packages for both, source and binary distribution.

@droidmonkey
Copy link
Member Author

The beauty of open source is you have the OPTION of compiling it by source ;-) The process is very turn key using cmake build tool. This issue has strayed a bit off message, fyi.

@Maxqia
Copy link

Maxqia commented Oct 6, 2016

@daniellandau grumbles angrily https://aur.archlinux.org/pkgbase/keepassx-http, now how are we going to merge :(

@daniellandau
Copy link
Contributor

@Maxqia I added you as co-maintainer to the AUR package.

@Maxqia
Copy link

Maxqia commented Oct 6, 2016

@daniellandau Merged the git side of things, now waiting for the package to be merged ;)

@ghost
Copy link

ghost commented Oct 31, 2016

Not binary but, Gentoo: https://bugs.gentoo.org/show_bug.cgi?id=598601

Is KeePassX-Reboot supposed to compile on FreeBSD, or there is a plan to have a native version?

Cheers!

@bms
Copy link

bms commented Nov 1, 2016

I'm still trying to resurrect some of my own development, but I made a few changes to the usage of CMake to allow building KScope (another KDE application) and generating DEBs using CMake's own generator.

@ghtux
Copy link

ghtux commented Nov 9, 2016

https://aur.archlinux.org/packages/keepassx-reboot-git/

So this will be the "official" maintained AUR repo? Already using that, just to be sure :-)

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Nov 9, 2016

I think there will be no "official" AUR repo unless a KeePassXC maintainer keep it updated.

That repo is maintained by @daniellandau but unfortunately is not updated to the 2.0.3 release and with the new project name.

When we release the 2.1.0 version we will address this issue (we are also working on AppImage and Snap)

@daniellandau
Copy link
Contributor

Not official by any means, but there is now https://aur.archlinux.org/packages/keepassxc-git/, which should have the comments+votes merged from the previous package soon.

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Nov 9, 2016

No problem it's free software, everybody can redistribute it.

@daniellandau If you can maintain it for every release (maybe with a ping from me or another maintainer) this can be the "official" AUR repo to me

@ghost
Copy link

ghost commented Nov 9, 2016

KeePassXC will be coming to Gentoo. There is a ebuild for git version already on bug tracker, but I think they will wait the v2.1.0 to add it to the portage tree.

https://bugs.gentoo.org/show_bug.cgi?id=598601

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Nov 9, 2016

Nice! @lebarondemerde

@northway
Copy link

What's latest on Ubuntu? The method is finalized just need someone to maintain is?

@phoerious
Copy link
Member

phoerious commented Jan 24, 2017 via email

@northway
Copy link

We have a public repository just need someone to maintain it, like putting out the latest versions, signing them etc ... ?

@phoerious
Copy link
Member

I would prefer having it in an official repository. Using a PPA or the like is only a temporary solution. We have to see what the deadlines and requirements are for getting into the repositories of the next Ubuntu release.

@northway
Copy link

It's from Ubuntu wiki:

Ubuntu regularly incorporates source packages from Debian, so it is encouraged to upload a package to Debian first to automatically have it in Ubuntu in due time. In addition to that your package will reach a much broader audience if it is in Debian and all of its derivatives.

In order to have faster reviews, several teams have been set up to manage a given subset of packages.

After some search, in nutshells the process would be like this:

  • Create a proper .deb package. - http://packaging.ubuntu.com/html/
  • Present the package in proper forum, so that the debian folks could review it. Package forums
  • If they accept it, it will appear in all Debian derivatives and later Ubuntu automatically import it to theirs.

Worth to mention, there are other ways as well. They prefer way that was mentioned above.

http://askubuntu.com/questions/16446/how-to-get-my-software-into-ubuntu

@phoerious
Copy link
Member

Thanks. We can create a deb automatically as part of our release procedure.

@ghost
Copy link

ghost commented Feb 10, 2017

KeePassXC is now on official Gentoo Portage tree.

@phoerious
Copy link
Member

Awesome! First distribution to add it to their official repositories. I'll update the website later.

@mattyjones
Copy link

I am starting work on an official Debian package. Looking at the thread above that should clear up some of the concerns around Ubuntu. Part of the idea behind creating a Debian package will be doing it in such a way that it is easily reproducible by others.

I am aware of the packages referenced on the site but in the spirit of keeping things clean I will be creating my own from scratch using the latest released source files. If I run into any issues or if we want to discuss this further I/anyone should create a new issue specific to Debian packaging.

Thanks!

@phoerious
Copy link
Member

phoerious commented Feb 23, 2017 via email

@samrocketman
Copy link

samrocketman commented Feb 23, 2017

Might I suggest a packaging repository related to packaging scripts for various platforms? ref: https://github.com/jenkinsci/packaging

One could create a team for contributors who are package maintainers, lock down the master branch (i.e. protect it via settings), and then can be liberal with allowing contributors r/w access to non-master branches. It also means all packaging-related issues can be created within that separate repo. Changes to master can be forced through peer review pull requests.

@ghost
Copy link

ghost commented Mar 9, 2017

Someone created a FreeBSD Port. Should be a matter of time to KeePassXC come to FreeBSD Ports collection.

@ghost
Copy link

ghost commented Mar 14, 2017

Now, it is officially on FreeBSD: https://svnweb.freebsd.org/ports?view=revision&revision=436151

@phoerious
Copy link
Member

I'll add it to the website in the evening.

@colans
Copy link

colans commented Mar 28, 2017

@droidmonkey
Copy link
Member Author

Closing this issue as we have substantial presence in multiple repos. Any specific issues should be opened in our distribution repository: https://github.com/keepassxreboot/keepassxc-packaging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests