Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No chance to save credentials from KeePassXC-Browser #755

Closed
Skeeve opened this issue Jan 16, 2020 · 10 comments
Closed

No chance to save credentials from KeePassXC-Browser #755

Skeeve opened this issue Jan 16, 2020 · 10 comments
Labels
bug PR pending A pull request for this feature or fix has been made

Comments

@Skeeve
Copy link

Skeeve commented Jan 16, 2020

Expected Behavior

When logging in to a site I would like to be able to save my credentials.

Current Behavior

I tried on gmx.net and on webmailer.hosteurope.de and both do not give me any option to save my credentials.

On gmx.net I see a banner at the top popping up for a fraction of a second when I log in, but I do not have any chance at all to reach one of the buttons, let alone read what the texts say.

On webmailer.hosteurope.de there is no banner at all and nothing is save in my KeePassXC Database.

Possible Solution

Could the icon in the username field, which activates the "fill from KeePassXC" check whether or not the fields are already filled and ask the user whether he wants to update/save the credentials from the fields to the DB?

Steps to Reproduce

  1. Go to https://www.gmx.net/ or https://webmailer.hosteurope.de/login.php
  2. Enter your credentials
  3. log in

Context

The Database is stored on a windows share, mounted on a Mac.

Debug Info

KeePassXC - 2.5.2
KeePassXC-Browser - 1.5.4
Operating system: MacIntel
Browser: Mozilla Firefox 72.0

Libraries:
???

Operating system: MacOS 10.14.6
CPU architecture: Intel
Kernel: ???

Enabled extensions:

For testing I disabled all extension except for KeePassXC-Browser

@varjolintu varjolintu transferred this issue from keepassxreboot/keepassxc Jan 16, 2020
@varjolintu varjolintu added the bug label Jan 16, 2020
@varjolintu
Copy link
Member

For the first site it's probably an extra redirect which needs to be handled. If you enter wrong credentials, the banner shows normally.

With the second site wrong credentials just launches an error page. Using Save Credentials from the context menu works.

I need to create test accounts for both sites and try this again later.

@Skeeve
Copy link
Author

Skeeve commented Jan 16, 2020

Thanks a lot @varjolintu. I always tried the Context menu, but always when the pointer was on the KeePassXC icon in the username field because that was the most logical place for me. But there is nothing in the context menu for KeePassXC-Browser. See:

image

When moving away from the icon, it works:

image

@varjolintu
Copy link
Member

The context menu works only with input fields, not on images.

@Skeeve
Copy link
Author

Skeeve commented Jan 16, 2020

When you explain it, it's obvious ;) But until then it wasn't obvious to me. Sorry for the confusion.

@droidmonkey
Copy link
Member

droidmonkey commented Jan 16, 2020

I've found that the banner goes away very easily lately. It should survive a couple redirects and subdomain name changes. I largely blame this on site owners though, they shouldn't be hopping around like crazed rabbits after you log in.

@varjolintu
Copy link
Member

I'll make the support for extra redirects when I have the time.

@matthiasdusch
Copy link

I can also confirm the issue with the fast redirect on several pages.
And I just created an account with a generated password and "secure answer" which I was not able to safe in the database because of that...

I came here to suggest a feature which allows to safe credentials before pressing "register" or "login". Turns out this already exists with the context menu. That's great!
Maybe it would be nice to "advertise" this feature a bit more or make it easier accessible like through the button in the firefox-menu.

Anyway thanks for your work!

@swdee
Copy link

swdee commented Feb 13, 2020

I also experience the same problem when logging in and the popup "save credentials" dialog disappears before I have time to read or click on the buttons due to the website being logged in doing redirects.

@varjolintu varjolintu added the PR pending A pull request for this feature or fix has been made label Feb 13, 2020
@georgehank
Copy link

Yup, something changed somewhere (I suspect it could be Chrome), but the banner disappears on correct password before you have any chance of interacting.

Given that I just changed my password and then couldn't enter the change (or rather, new account)… that's bad.

@varjolintu
Copy link
Member

Hang on tight. We are releasing the next version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR pending A pull request for this feature or fix has been made
Projects
None yet
Development

No branches or pull requests

6 participants