Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of deleting an entry permanently inside a shared database, can the deleted entry be placed in the recycle bin of the original database? #10248

Closed
oybekkamolov opened this issue Jan 30, 2024 · 6 comments

Comments

@oybekkamolov
Copy link

oybekkamolov commented Jan 30, 2024

Summary

When I delete an entry from inside a shared database, the entry gets deleted permanently. Is there anyway to place the entry in the recycle bin of the database that is doing the sharing?

Examples

  • group "Accounts" is shared
  • The name of the shared group is "Shared Accounts"
  • User opens "Shared Accounts" and accidentally deletes an entry
  • Instead of the entry getting deleted permanently, it gets stored in the Recycle Bin of the "Accounts" group

Context

Some of the people that we share passwords with are not technically savvy. So, I want to be able to restore entries in case of accidental deletion.

@droidmonkey
Copy link
Member

droidmonkey commented Jan 30, 2024

I just tested this and shared entries are properly moved to the recycle bin. Make sure the recycle bin is actually enabled in the user's database:

image

@oybekkamolov
Copy link
Author

Ah I did not notice that option. Thank you!

I think there might be a bug. After I delete an entry, the "Use recycle bin" checkbox keeps getting unchecked. Also, the recycle bin entries are showing up in the shared group.

@droidmonkey
Copy link
Member

droidmonkey commented Jan 30, 2024

Technically entries are not deleted until they are actually deleted, there are plenty of keeshare "issues" that are actually how it was designed. On the roadmap for an overhaul...
https://github.com/keepassxreboot/keepassxc/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22feature%3A+KeeShare%22

#2798

@oybekkamolov
Copy link
Author

Video.1-30.at.18.26.webm

What about the "Use Recycle Bin" checkbox getting unchecked?

@oybekkamolov
Copy link
Author

image
Also, I just noticed 3 recycle bins were created

@droidmonkey
Copy link
Member

droidmonkey commented Jan 30, 2024

You don't set the recycle bin on the share, you set it on the host database. You have "three" bins because the share created one and synced it then disabled it. See the issue I linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants