Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passkeys: Improve usability of "Add to existing" #10714

Open
darkdragon-001 opened this issue May 8, 2024 · 4 comments
Open

Passkeys: Improve usability of "Add to existing" #10714

darkdragon-001 opened this issue May 8, 2024 · 4 comments

Comments

@darkdragon-001
Copy link

Summary

First of all thanks a lot for adding this great feature!

It would be nice if one could (additionally) get a filtered list of matching existing entries similar to auto-fill when trying to add a passkey to an existing entry (without passkey so far).

Examples

Could look similar to the dialog when filling in data to a website. Should filter based on URL or additional URL fields.

Context

I have a huge database with a lot of groups.

@droidmonkey
Copy link
Member

droidmonkey commented May 8, 2024

We decided not to do that. Instead, it must match both username and url of an existing passkey entry for the dialog to offer to update that entry. Otherwise, you choose the "register to existing" and choose the entry you want.

Perhaps that register to existing dialog could include a search box @varjolintu.

@darkdragon-001
Copy link
Author

@droidmonkey I tried GitHub and Google and I had to manually choose the group and entry. The username and url fields in the entry are used successfully for password based login. So are you saying it should work but doesn't?

@droidmonkey
Copy link
Member

agreed this needs to be improved

@darkdragon-001
Copy link
Author

darkdragon-001 commented May 15, 2024

How is the URL compared? Does github.com (passkey relying party) match https://github.com/ (URL field)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants