Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show last used time/grant time for browser integration keys #4340

Closed
rugk opened this issue Feb 17, 2020 · 5 comments · Fixed by #4392
Closed

Show last used time/grant time for browser integration keys #4340

rugk opened this issue Feb 17, 2020 · 5 comments · Fixed by #4392

Comments

@rugk
Copy link

rugk commented Feb 17, 2020

Summary

It would be nice to have the "last used" date/time column in the browser integration panel.

Desired Behavior

In the DB settings -> browser integration, where the keys for the integrations are listed, there should be a column for when that connection has last been used.

Maybe also, when it was added?

Possible Solution

So maybe two columns.

Context

The problem is when looking at the list the identifiers (which I mainly name after browser/profile) may not be enough to really know when I have granted that thing, and whether I can revoke it.
To "cleanup" old entries it may just be useful to revoke all entries that were used long ago. 🤔

@varjolintu
Copy link
Member

varjolintu commented Mar 2, 2020

"Created" is quite easy to implement. "Last Used" must be implemented in a way that it's only updated when connecting to the database (or when requesting credentials). Updating the timestamp on every action causes a lot of updates to the database, as the custom data would be constantly updated on every request.

EDIT: At this point we are only implementing "Created". Let's discuss the possible "Last Used" later.

@rugk
Copy link
Author

rugk commented Mar 7, 2020

So #4392 was just about the created column. May we then reopen this issue or so for the "Last Used" later?

@varjolintu
Copy link
Member

@rugk I'm ok with reopening this with a modified title. However, "Last Used" is something that must be discussed: how to implement it, or implement at all. I'm worried about the constant changes to the database, so the connection process itself must be modified or we have to figure out how to save the "Last Used" state without rewriting to the custom data all the time.

@rugk
Copy link
Author

rugk commented Mar 7, 2020

Maybe once a day is enough? I guess we don't need a time, so having the date there is enough.

@droidmonkey
Copy link
Member

I have no interest in adding additional meta data to the connection id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants