Usability issue when copying fields

[Robert941]

Steps to reproduce issue
Open entry editor
Modify password field
Click "Copy Password" button on upper toolbar
Old password is copied to clipboard instead of new

Current solution
Click "Apply" before clicking "Copy Password"

Why this is an issue
This does not match the behavior of the "Copy Password" button in the password generator.
User could copy unintended data to clipboard (failure could go unnoticed due to password masking with asterisks).

Notes
This applies to the username, password, and URL fields.

Considerations
Preferable to maintain ability to click "Cancel" and discard any edits (implementing an "Auto Apply" feature would not be ideal).

[droidmonkey]

This was brought up before and we decided not to change the behavior as it is incredibly hard to do so. You are editing an entry, so any changes you make are not baked into the database representation in memory until you hit apply or ok. In order to fix this we'd have to make hundreds of code changes. We just aren't going to do that, sorry.

[Robert941]

@droidmonkey What about adding a "Copy" button next to the field similar to the password generator's "copy" button?

[droidmonkey]

You can select the text and right click copy or press Ctrl+C once selected. I actually thought about this more and we can pipe copy requests to the edit view if it is visible. I think this is possible and desirable.

[Robert941]

That would be great since highlighting and copying introduces two risks.

1. Accidentally modifying the text in the field
2. Accidentally not highlighting the entire field (only copying part of the field)

[sjvudp]

droidmonkey commented on Jul 6, 2022

(...) it is incredibly hard to do so (...)

Taking a value from RAM is "incredibly hard"??? I mean if you can display it, why can't you copy it?