Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please make LookupErrorKind public #10

Closed
miquels opened this issue Sep 24, 2018 · 4 comments
Closed

please make LookupErrorKind public #10

miquels opened this issue Sep 24, 2018 · 4 comments

Comments

@miquels
Copy link

miquels commented Sep 24, 2018

getnameinfo and getaddrinfo return an error of type LookupError, which has a method kind() which returns a LookupErrorKind enum. Unfortunately, LookupErrorKind is not made public, so it cannot be used.

Please add pub use err::LookupErrorKind to lib.rs. Thanks :)
@keeperofdakeys
Copy link
Owner

Whoops, looks like that was an oversight on my part. I'll release a fix for this in the next few days.

@keeperofdakeys
Copy link
Owner

I've pushed a fix for this to git master, can you verify this does what you need? After that I'll push an update to creates.io.

@miquels
Copy link
Author

miquels commented Oct 6, 2018

Allright, this code now compiles: miquels/nntp-rs@330fb12

Thanks!

@keeperofdakeys
Copy link
Owner

Alright, I've pushed version 1.0.0 to crates.io. Thanks again for the bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keeperofdakeys @miquels