Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.0.4 fails with ' error: expected an item keyword' #16

Closed
adrianreber opened this issue Oct 19, 2020 · 3 comments
Closed

Update to 1.0.4 fails with ' error: expected an item keyword' #16

adrianreber opened this issue Oct 19, 2020 · 3 comments

Comments

@adrianreber
Copy link

The pull request from dependabot to upgrade dns-lookup to 1.0.4 fails with:

error: expected an item keyword
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/dns-lookup-1.0.4/src/lookup.rs:59:7
   |
59 |       unsafe {
   |       ^^^^^^
   | 
  ::: /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/cfg-if-0.1.9/src/lib.rs:41:40
   |
41 |         if #[cfg($($meta:meta),*)] { $($it:item)* }
   |                                        -------- while parsing argument for this `item` macro fragment

error: aborting due to previous error

error: could not compile `dns-lookup`.

Not sure if this is because of other dependencies or why it happens. The corresponding pull request is here: adrianreber/mirrorlist-server#53

Is there anything I need to change in my project?

@keeperofdakeys
Copy link
Owner

Using item in that macro in cfg-if is wrong, it should be tt. The version failing here is cfg-if 0.1.9, and this issue appears to have been fixed in cfg-if 0.1.10 - rust-lang/cfg-if@88456aa.

As cfg-if 1.0.0 has been released, I'll update the cargo.toml to use it and push another minor update.

@keeperofdakeys
Copy link
Owner

Okay I've pushed version 1.0.5 for this, let me know if you still have a build failure.

@adrianreber
Copy link
Author

Thanks a lot for the quick fix. Errors are now resolved and I updated to dns-lookup 1.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants