-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS support for HTTP handler #20
Comments
Unfortunately, no success with testing locally with self-signed certificates. What I've tried:
Any help is appreciated. |
Hey @keeprocking are you still looking for help on this? |
Yep. If you are willing to help, that would be great. |
#45 adds a new I did not add any tests. I can give that a go this week. |
Thanks a lot for this! Unfortunately, I caught a cold or something but will try to look into this as soon as possible - please give me some time. 🙂 As for the tests: that would be great. A new Graylog handler should be added to the |
No rush - hope you feel better soon! I added tests for the new handler. They all pass locally. However, I'm not able to get tests to pass with certificate verification. Still working on that |
Ah, ok, I'm able to run tests with certificate verification now. There are two issues with the TLS tests currently:
I can include a new unencrypted keypair in the PR if you'd like, along with a change to the bootstrap script to not supply |
Smee again, alive and well. 😉
Yes, please do - that'd be awesome. |
Done! I uncommented tests for I included a slightly modified version of the I also added a step in the bootstrap script to fix ownership and permissions on |
You did a truly amazing job here, thank you so much! The PR is merged into master. |
Happy to help! |
As pointed out in #1 (comment), HTTPS support should be added
The text was updated successfully, but these errors were encountered: