Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GelfKafkaHandler #35

Open
cejus opened this issue Jan 9, 2019 · 2 comments
Open

GelfKafkaHandler #35

cejus opened this issue Jan 9, 2019 · 2 comments

Comments

@cejus
Copy link

cejus commented Jan 9, 2019

Hi guys,

what I needed is the feature that logs created in my pyhton code (e.g. "logger.info("whatever")") are converted into the GELF format and then sent via a Kafka bus to graylog (Gelf Kafka Input). I found this module here and it provided nearly exactly what I needed - except the "GelfKafkaHandler".

I was thinking of a additional Handler and were glad to see that such an additional handler was very easy to implement. I wrote some additional lines of code and tested it on a local setup - it works !

So now - please let me know what you are thinking! Is this a sensible feature?

Looking forward to get your feedback.

@keeprocking
Copy link
Owner

Hey @cejus!

Sounds pretty good. If you have a working solution for this, could you please prepare a PR? I'm sure this functionality would be useful for other people out there.

Thank you!

@cejus
Copy link
Author

cejus commented Jan 13, 2019

Hey @keeprocking,

sorry for my late response! I was very busy the last days.
Created the PR #36.

What is still to do at first is an enhancement of your testing infrastructure to test the additional feature. I tested it on my local machine but I think such an enhancement is still required.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants