Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation module: General differentiation between Root and Representation METS? #159

Open
PhillipAasvangTommerholt opened this issue Jun 26, 2023 · 4 comments
Assignees
Milestone

Comments

@PhillipAasvangTommerholt
Copy link

PhillipAasvangTommerholt commented Jun 26, 2023

The CSIP makes it possible to have a single METS.xml describing the whole package (called the Root METS) but the CSIP also allows to have METS.xml files in the representation folders (called Representation METS). When running the validator (v. 2.3.3) up against the test corpus it seems that the validator module is currently only build to validate Root METS. An example hereof can be found when validating this package. The validator only finds the CSIP21 error in the Root METS.xml, not the error in the Representation METS.xml

@PhillipAasvangTommerholt PhillipAasvangTommerholt changed the title Validation module: Generalt differentiation between Root and Representation METS? Validation module: General differentiation between Root and Representation METS? Jun 26, 2023
@prettybits
Copy link

I just observed a similar behavior, but the other way around in #161. Not sure if this is just inconsistent across different rules and depends on the rule in question or whether there's a pattern here.

Btw @PhillipAasvangTommerholt, if I may ask here, you say "called the Root METS", but the CSIP specification says and specifically points out in 5.1 that it is called "Package METS" ("root" seems to mainly be used for indicating the position within the folder hierarchy or when talking about the root element from an XML perspective). Just wondering if this is to be used interchangably in practice in which case it may warrant mention in the spec?

@PhillipAasvangTommerholt
Copy link
Author

@prettybits I think it is me that is still stuck in an old terminology. I think I will need to call it Package METS accordingly with the CSIP :-)

@hmiguim hmiguim added this to the 2.3.4 milestone Aug 4, 2023
@carlosjepard
Copy link
Contributor

carlosjepard commented Aug 4, 2023

Hello Philip!
I have tested this, and it worked as expected. Please try it with this cli and use it on the sip i sent. (The package you mentioned had problems with the the sub mets)
The cli and sip are in following zip
CommonsIPTest.zip

@hmiguim hmiguim modified the milestones: 2.4.0, Next Version Aug 7, 2023
@carlosjepard
Copy link
Contributor

Hello Philip!
Do you have any updates regarding this issue?
Best regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants