Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache siegfried version #1368

Closed
luis100 opened this issue Oct 4, 2018 · 1 comment
Closed

Cache siegfried version #1368

luis100 opened this issue Oct 4, 2018 · 1 comment
Assignees
Milestone

Comments

@luis100
Copy link
Member

luis100 commented Oct 4, 2018

The command is called on every execution, which is an overkill. Use a Guava cache to cache the version with a sensible timeout.

@luis100 luis100 added this to the 2.3.0 milestone Oct 4, 2018
@luis100 luis100 self-assigned this Oct 4, 2018
@luis100
Copy link
Member Author

luis100 commented Oct 15, 2018

Skipping unnecessary getVersion instead.

@luis100 luis100 closed this as completed Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant