Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow in config/temporal.php to over ride the WorkerFactory::class that is being used by the worker #23

Closed
slnw opened this issue Oct 17, 2023 · 2 comments

Comments

@slnw
Copy link
Contributor

slnw commented Oct 17, 2023

WorkerFactory::class allows to define many configurations in the Temporal workflow, it's important when using this package that a user can easily extend the WorkerFactory class and make changes as necessary.

Another option is to allow to change the default Worker command in WorkCommand:

            ...['-o', sprintf('server.command=%s ./vendor/bin/roadrunner-temporal-worker', (new PhpExecutableFinder())->find())],

add here an option to override the roadrunner-temportal-worker path.

@cappuc
Copy link
Contributor

cappuc commented Oct 17, 2023

What options do you need to customize?

I prefer not to add too much complexity so for simple things we can add options to config file and for more advanced use cases we can allow to override the command path

@slnw
Copy link
Contributor Author

slnw commented Oct 18, 2023

Hi, I would like to to implement the exception handling like mentioned in - temporalio/sdk-php#103 (comment)

@cappuc cappuc closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants