Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect kdbx password makes request to WebDAV with password as "undefined" (resulting in 401) #1319

Closed
lwis opened this issue Oct 22, 2019 · 1 comment
Assignees
Labels
storage Storage providers: Dropbox, Google, WebDAV, etc... Type ◦ Bug Something isn't working
Milestone

Comments

@lwis
Copy link

lwis commented Oct 22, 2019

Describe the bug
Incorrect kdbx password makes request to WebDAV with password as "undefined" (resulting in 401)

To Reproduce
Steps to reproduce the behavior:

  1. Use WebDAV
  2. Attempt to unlock keychain with incorrect password
  3. See 401 response.

Expected behavior
For the request not to take place, and for an incorrect password notification to appear instead.

Environment
Using the app on macOS, 2019-10-16:v1.11.10.

Kdbx File
Any.

Logs

[INFO ] 2019-10-22T11:16:59.592Z [open:Personal] File open request
[INFO ] 2019-10-22T11:16:59.593Z [open:Personal] Open file from cache, will sync after load webdav
[DEBUG] 2019-10-22T11:16:59.593Z [storage-cache] Load xxxx
[DEBUG] 2019-10-22T11:16:59.594Z [storage-cache] Loaded xxxx 1ms
[INFO ] 2019-10-22T11:16:59.594Z [open:Personal] Loaded file from cache null
[DEBUG] 2019-10-22T11:16:59.630Z [argon2] WebAssembly runtime loaded (main thread) 34ms
[DEBUG] 2019-10-22T11:17:01.250Z [argon2] Hash computed 1617ms
[ERROR] 2019-10-22T11:17:01.252Z [file] Error opening file InvalidKey Error InvalidKey KdbxError: Error InvalidKey
[INFO ] 2019-10-22T11:17:01.252Z [open:Personal] Error loading file from cache, trying to open from storage KdbxError: Error InvalidKey
[INFO ] 2019-10-22T11:17:01.252Z [open:Personal] Open file from storage webdav
[INFO ] 2019-10-22T11:17:01.252Z [open:Personal] Stat file
[DEBUG] 2019-10-22T11:17:01.252Z [storage-webdav] Stat https://...kdbx
[DEBUG] 2019-10-22T11:17:01.373Z [storage-webdav] Stat error https://...kdbx 401 121ms
[INFO ] 2019-10-22T11:17:01.373Z [open:Personal] Stat error HTTP status 401
[ERROR] 2019-10-22T11:17:01.373Z [open-view] Error opening file HTTP status 401
@antelle antelle added Type ◦ Bug Something isn't working storage Storage providers: Dropbox, Google, WebDAV, etc... labels Oct 22, 2019
@antelle antelle added this to the v1.12 milestone Oct 22, 2019
@antelle antelle self-assigned this Oct 26, 2019
@tbradsha
Copy link

Thanks for fixing this. I was about to file a bug report that resulted as a side effect: the password field wouldn't regain focus, so I'd have to manually select it to type the correct password again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage Storage providers: Dropbox, Google, WebDAV, etc... Type ◦ Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants