Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs: minimize/close, auto-lock, new extension [macOS] #1820

Closed
nlydv opened this issue May 17, 2021 · 3 comments
Closed

Bugs: minimize/close, auto-lock, new extension [macOS] #1820

nlydv opened this issue May 17, 2021 · 3 comments
Assignees
Labels
Build ◦ Desktop Specific to desktop Build ◦ Mac Specific to macOS Type ◦ Bug Something isn't working
Milestone

Comments

@nlydv
Copy link

nlydv commented May 17, 2021

macOS Catalina (10.15) & Brave Browser (chromium)

Minimize

The "minimize to taskbar instead of close" feature seems to have broken (disabled?) after the latest updates. With the setting activated, closing the window still doesn't quit the app entirely but the taskbar icon never shows up anymore and the app icon in dock remains.

Auto-lock

In addition, the auto-lock settings seem to be ignored when "minimized". None of the auto-lock triggers are enabled in the app, yet it always ends up getting locked anyways. Functionally, the effect of "minimizing on close" seems to be the same as actually quitting, except it still shows up in the dock as a running app.

New extension

Pretty much makes using the new KeeWeb Connect extension pointless unless I always keep it as a visible (or actually minimized) window at all times. I was previously using the keewebhttp plugin with 3rd party browser extension and that doesn't seem to work anymore either. Tried on Safari just to test it, desktop app connected then disconnected, Safari extension page still thinks it's connected.

Will probably end up uninstalling and rebuilding prior version from source.

Still excited to see a dedicated extension with multi-browser support being worked on though!
Unless I'm the only one with these issues, maybe it would've been better to have initially pushed it as a beta release branch?

@antelle
Copy link
Member

antelle commented May 17, 2021

Hi!

Minimize instead of close is somewhat unloved feature, both in Electron, and as a consequence, in KeeWeb. The API is a bit not consistent across operating systems, and not many people are using it, so you may find it not very smooth.

The "minimize to taskbar instead of close" feature seems to have broken

✅ I can confirm, it behaves like this for me too, will look into it

auto-lock settings seem to be ignored when "minimized"

🚫 You mean, closed? Because you can't minimize the app on macOS now. When KeeWeb is closed, it's always locked, there's no way to prevent it. So, this works as expected.

Safari extension page still thinks it's connected.

🚫 Extensions unfortunately cannot send events to Safari without a request from the browser. If you refresh the extension options page in Safari, it will show that it's disconnected. Works not as it should do ideally, but expected.

rebuilding prior version from source.

❗ It will not include KeeWebHttp, this plugin has already been removed from the gallery.

beta release branch?

There's no beta release for desktop now, not sure if there would be enough audience for a beta version. Maybe yes.

@antelle antelle added Type ◦ Bug Something isn't working Build ◦ Desktop Specific to desktop Build ◦ Mac Specific to macOS labels May 17, 2021
@antelle antelle added this to the v1.18.x milestone May 17, 2021
@nlydv
Copy link
Author

nlydv commented May 18, 2021

Thanks for the reply @antelle.

Minimize instead of close ... not many people are using it

Really? That's surprising. From a UI/UX perspective it's one of the reasons that got me to choose KeeWeb after trying all the other clients out there!

You mean, closed?

Yeah, the auto-lock issue occurred for me when I expected closing to actually just minimize to system tray. I assumed that the unexpected auto-locking behavior would resolve itself if the minimize feature was working. Though I wasn't sure if that's actually how all that is handled internally, so I figured I'd mention its own thing anyways.

If you refresh the extension options page in Safari, it will show that it's disconnected.

I did try this to see if it would update but it still would show as connected. After I uninstalled the desktop app (before uninstalling the safari extension itself), even then when refreshing the page it thought it was connected, or at least the frontend webpage said it was anyways.

It will not include KeeWebHttp, this plugin has already been removed from the gallery.

Realized this after downgrading, but I was able to recover a local copy thankfully. Does the KeePassXC extension integration works as a universal stand-in for KeeWebHttp? If not perhaps deprecating the old plugin rather than full removal would be helpful for those on prior versions in the near-term.

not sure if there would be enough audience for a beta version

Well I guess you've got at least one beta tester here already!

@antelle antelle self-assigned this May 19, 2021
@antelle
Copy link
Member

antelle commented May 19, 2021

Fixed minimize on close on macos, a release with it should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build ◦ Desktop Specific to desktop Build ◦ Mac Specific to macOS Type ◦ Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants