✨ Add Author Github homepage url if exists (fixes #124)

[anku255]

Hi @kefranabg !

I am referring Author's Github Website page URL as Author Homepage in the codebase. Please let me know if you want me to change this.

Some points that will help during the code review:

• Screenshot of the README

• I am using node-fetch library to make the get request.

• I have added some tests but I guess I need to add a few more to get 100% code coverage. I will do that soon.

• I needed to update the snapshots to make the tests pass.

Please take a look and let me know what you think.
Thank you.

[codecov]

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #145   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     27    +1     
  Lines         211    226   +15     
  Branches       23     26    +3     
=====================================
+ Hits          211    226   +15

Impacted Files	Coverage Δ
src/questions/index.js	100% <ø> (ø)	⬆️
src/project-infos.js	100% <100%> (ø)	⬆️
src/utils.js	100% <100%> (ø)	⬆️
src/questions/author-website.js	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b8bc08...c6bc952. Read the comment docs.

[kefranabg]

Hi @anku255,

Sorry for the delay... I've been busy these last days. I'll do a review very soon.
Looks great !

[anku255]

Hi @anku255,

Sorry for the delay... I've been busy these last days. I'll do a review very soon.
Looks great !

Hi!!

No Problem! Please let me know if you need help with anything :)

[kefranabg]

@anku255,

First thanks for the PR, this is great work 💪

I just added a few changes:

• Renaming Homepage to Website
• Move Website question just after Github username question
• Made an improvement on the website question: now, if the user uses a github username different that the one that has been proposed by readme-md-generator, it will dynamically fetch the website url using the new username (and not the one that had been found before the question process starts. See these changes)

Please let me know if you're ok with my changes. Thanks

[anku255]

@kefranabg Thank you for the kind words. Your change looks great. So thoughtful of you to fetch author's website dynamically if user enters a different user name.

This was by far my biggest PR ( considering the number of files I had to change). It's been great working on this project and I would like to continue doing so in the future. ☺️

[kefranabg]

Awesome ! Feel free to contribute again or open new issues if you have features ideas 👍