Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Use gender neutral in comment #174

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Nov 4, 2019

Hi!

I was going through the source code and found a comment referring to the user as 'he'. To make it gender-neutral, I changed it to 'they'. We can even remove the comment if its unnecessary.

Thank you.

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #174   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines         227    227           
  Branches       26     26           
=====================================
  Hits          227    227
Impacted Files Coverage Δ
src/ask-overwrite.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279711f...7afbba7. Read the comment docs.

src/ask-overwrite.js Outdated Show resolved Hide resolved
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
@kefranabg kefranabg changed the title 🌈 Use gender neutral comments ✏️ Use gender neutral in comment Nov 5, 2019
@kefranabg
Copy link
Owner

Thanks for this!

@kefranabg kefranabg merged commit 9f78778 into kefranabg:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants