✨ Ask author's linkedin username (fixes #170) #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 27 28 +1
Lines 227 229 +2
Branches 26 26
=====================================
+ Hits 227 229 +2
Continue to review full report at Codecov.
|
|
Nice job @anku255! What do you think of using 💼 ? |
kefranabg
reviewed
Nov 8, 2019
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
kefranabg
reviewed
Nov 9, 2019
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
kefranabg
changed the title
kefranabg
approved these changes
Nov 9, 2019
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR fixes #170.
I was confused about the emoji for LinkedIn (shown while asking for username). I ended up going with 🕴instead of 👤 but I am not sure about it. What do you think about it?
Let me know of any changes if required.
Thank you.