Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Filter social network inputs to remove potential @ #93

Merged
merged 6 commits into from
Jul 8, 2019

Conversation

Slashgear
Copy link
Contributor

Fix #92

In order to help user, it will remove the prefixed @ if the user write it in the prompt.

  • update unit tests

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #93   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines         187    190    +3     
  Branches       21     21           
=====================================
+ Hits          187    190    +3
Impacted Files Coverage Δ
src/questions/author-twitter.js 100% <100%> (ø) ⬆️
src/utils.js 100% <100%> (ø) ⬆️
src/questions/author-github.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2be60e...226fcd2. Read the comment docs.

kefranabg
kefranabg previously approved these changes Jul 8, 2019
src/utils.spec.js Outdated Show resolved Hide resolved
Co-Authored-By: Franck Abgrall <abgrallkefran@gmail.com>
@kefranabg
Copy link
Owner

Thanks for your work @Slashgear ! 💪

@kefranabg kefranabg changed the title ✨ un-prefix github and twitter username to remove @ ✨ Filter social network inputs to remove potential @ Jul 8, 2019
@kefranabg kefranabg merged commit ccae357 into kefranabg:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter and Github username @
2 participants