Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing timestamp content in utils.py? #1

Closed
iRuizeWu opened this issue May 8, 2023 · 4 comments
Closed

Missing timestamp content in utils.py? #1

iRuizeWu opened this issue May 8, 2023 · 4 comments

Comments

@iRuizeWu
Copy link

iRuizeWu commented May 8, 2023

In dump_datatape there should be a store for the timestamp.

@KegangWangCCNU
Copy link
Owner

Thank you for your attention. Timestamps can be used to calculate the sampling rate, which is necessary in heart rate estimation. However, the end-to-end model outputs waveforms rather than directly outputting heart rates, so it actually does not need timestamps for training. If you need to test the model, please use a dataset with timestamps instead of datatape. If your model must use timestamps, you can generate them yourself because the sampling rate of most datasets is usually 30fps or set the sampling rate according to your dataset and then generate uniform timestamps using np.arange.

@iRuizeWu
Copy link
Author

iRuizeWu commented May 12, 2023

I still run into some problems. Shouldn't we use eval_on_dataset when testing? It will show that the timestamp, path attributes are missing. So, the tests should be rewritten by myself. My dataset is pure.

@KegangWangCCNU
Copy link
Owner

Please make sure you are passing in a dataset file, not a datatape file. Dataset files can be used to generate datatape and for testing, while datatape is only used for training. If your issue is still not resolved, please show your code so I can further identify the problem. Additionally, I recommend reading our tutorial

https://github.com/KegangWangCCNU/PhysBench/blob/main/Tutorial/Noob%20Heart.ipynb

to understand how it works.

@iRuizeWu
Copy link
Author

Oh! Thanks ! I mistakenly used datatape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants