Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename skip to seek/relseek/move #50

Closed
keichi opened this issue Aug 22, 2017 · 0 comments · Fixed by #122
Closed

Rename skip to seek/relseek/move #50

keichi opened this issue Aug 22, 2017 · 0 comments · Fixed by #122
Assignees
@keichi

Comments

@keichi
Copy link
Owner

keichi commented Aug 22, 2017

Based on the discussion in #27, skip() should be renamed to a more neutral name to imply that it can move the current pointer not only forward but also backward.
@keichi keichi self-assigned this Jun 11, 2019
@keichi keichi mentioned this issue Jun 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keichi keichi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename skip() to seek() keichi/binary-parser
1 participant
@keichi