Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing after cleanup #30

Closed
Thielak opened this issue Apr 15, 2017 · 4 comments
Closed

Spacing after cleanup #30

Thielak opened this issue Apr 15, 2017 · 4 comments

Comments

@Thielak
Copy link
Contributor

Thielak commented Apr 15, 2017

I noticed that after the change in cleanup.py 134eb73#diff-a9aa9e742ec99f1936ff8c8aa2c4b9d7 there's a weird issue with spacing that occurs at the cleanup stage before the output is sent to the user.
As you can see the phrase is still intact after the denormalization, but spaces are added at cleanup

image

@keiffster
Copy link
Owner

Ok I'll take a look over Easter and see what the problem is

@keiffster
Copy link
Owner

Back from vacation, I'm am currently taking a look at this along with refactoing the implications of upper and lower case text throughout the system

I'm thinking about a weeks time I'll have a solution which solves both

@keiffster
Copy link
Owner

Check out the latest release on master I've just pushed this afternoon. Updated the pre and post cleanup o[erators which now deal with punctuation and quotation much better

@Thielak
Copy link
Contributor Author

Thielak commented May 3, 2017

Thank you for taking the time to look into it, now it works much better!

@Thielak Thielak closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants