Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong depth decoding #7

Open
sergiobd opened this issue Jan 20, 2020 · 1 comment
Open

Wrong depth decoding #7

sergiobd opened this issue Jan 20, 2020 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@sergiobd
Copy link

sergiobd commented Jan 20, 2020

Hi Keijiro,

I'm opening another issue related to artifacts on depth data. I have been having wrong depth decoding which I first thought was due to hap conversion, then depth clipping. Now I've tracked down the problem to the RGB2Hue function in depthkit's shader code, and I solved it, though it still puzzles me why this does not happen on your captures.

Your capture:

My capture from Azure (has some strange depth segments):

If I replace the RGB2Hue function in Depthkits Common.hsls (I'm using these), the problem gets solved:

Posting this here in case someone runs into the same issues.

@keijiro keijiro self-assigned this Jan 20, 2020
@keijiro keijiro added the question Further information is requested label Jan 20, 2020
@cpkcpkcpk
Copy link

@sergiobd I've been having the same issue for years with all my Depthkit clips shot with Azure Kinect. Is there any chance you could share the changes you made to Depthkit's Common.hsls? I looked at the functions you linked, but not really sure how to replace it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants