Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to the status #49

Closed
kevdowney opened this issue May 29, 2020 · 2 comments
Closed

Add metrics to the status #49

kevdowney opened this issue May 29, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@kevdowney
Copy link

Is your feature request related to a problem? Please describe.
Add:

  • Total
  • LastSuccess
  • LastFailure

Describe the solution you'd like
A clear and concise description of what you want to happen.

Have you thought about contributing yourself?

Open Source software thrives with your contribution. It not only gives skills you might not be able to get in your day job, it also looks amazing on your resume.

If you want to get involved, check out the
contributing guide, then reach out to us on Slack so we can see how to get you started.

@kevdowney kevdowney added the enhancement New feature or request label May 29, 2020
@RaviHari
Copy link
Collaborator

@kevdowney this is already available from this PR: #35

image

Are you looking for LastFailure workflow and Total as separate fields in status?

@vasukiprasad1
Copy link
Member

The idea here is to capture the custom return message from the workflow controller and based on the message derive the status of the workflow(success/failure). Along with the monitoring counter, it will be nice to have a binary type of reporting for workflow status. Setting the alert makes it easier and manageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants