Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for linting using golangci-lint #176

Open
kevdowney opened this issue Dec 16, 2022 · 0 comments
Open

chore: Add support for linting using golangci-lint #176

kevdowney opened this issue Dec 16, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@kevdowney
Copy link
Collaborator

kevdowney commented Dec 16, 2022

Is this a BUG REPORT or FEATURE REQUEST?:
CHORE
What happened:
Need to start linting the codebase
What you expected to happen:

  • Add a makfile target to download and run golangci-lint
  • Add a github action to run linter as a pr gate.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Addon Manager version
  • Kubernetes version :
$ kubectl version -o yaml

Other debugging information (if applicable):

  • Addon status:
$ kubectl describe addon <addon-name>
  • controller logs:
$ kubectl logs <addon-manager-pod>
@kevdowney kevdowney added the good first issue Good for newcomers label Jan 15, 2023
@kevdowney kevdowney changed the title Add support for linting using golangci-lint chore: Add support for linting using golangci-lint Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant