Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amnios support for disk 1 is incorrect #169

Closed
rhester72 opened this issue Mar 23, 2023 · 8 comments
Closed

Amnios support for disk 1 is incorrect #169

rhester72 opened this issue Mar 23, 2023 · 8 comments

Comments

@rhester72
Copy link

Please see the details in this post/thread:

http://eab.abime.net/showpost.php?p=1604430&postcount=45

The short version is the PROTEC track 0 on side 1 does not appear to be encoded correctly with disk-analyse per the CAPS/SPS team (as compared to the official encoder).

I can provide disk-analyse and SPS images for comparison if helpful.

@keirf
Copy link
Owner

keirf commented Mar 23, 2023

Raw dump and SPS IPF please. Should be easy to fix.

@keirf
Copy link
Owner

keirf commented Mar 23, 2023

Ah I see they are in the Zone

@keirf
Copy link
Owner

keirf commented Mar 23, 2023

To be clear, the disk-analyse generated IPF does not pass the protection check?

@rhester72
Copy link
Author

rhester72 commented Mar 23, 2023

It seemed to to me - the game worked as expected. I didn't know anything was amiss until dlfrsilver commented about it in the longer thread (page 3):

http://eab.abime.net/showthread.php?p=1604447#post1604447

@keirf
Copy link
Owner

keirf commented Mar 23, 2023

If it works, it works. I'll have a look though.

@keirf
Copy link
Owner

keirf commented Mar 23, 2023

I can't see any important difference. Track length differs slightly but should still be a "good" PROTEC track. I have responded on EAB. Perhaps dlfrsilver spotted something else, or perhaps he believes the track length difference is important. I doubt it is. If it passes the in-game protection check it is good enough for me.

@rhester72
Copy link
Author

Understood - I'm with you on this one, but there's long been a divide between 'preservation' and 'playability' as far as the SPS group is concerned. From where I sit, neither is good enough for preservation - only raw flux is. shrugs

@keirf
Copy link
Owner

keirf commented Mar 23, 2023

Yes for preservation it should always be the original flux. Downstream formats always lose detail. For example in this case both analysers replace the true track gap value with 00. So even the SPS analyser is far from 100% accurate. I just don't pretend to be and I know what the PROTEC code tests for! My bar for acceptability is that the converted image works with the original track loader and protection checks. Actually that is true for SPS too but they won't admit it.

@keirf keirf closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants