Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 support #9

Closed
bersbersbers opened this issue May 7, 2020 · 6 comments · Fixed by #7
Closed

Python 3.8 support #9

bersbersbers opened this issue May 7, 2020 · 6 comments · Fixed by #7
Assignees
Labels
enhancement New feature or request

Comments

@bersbersbers
Copy link

user@host:~/pip_patches> python --version
Python 3.8.2
user@host:~/pip_patches> pip install tf-keras-vis==0.2.2
ERROR: Could not find a version that satisfies the requirement tf-keras-vis==0.2.2 (from versions: 0.0.1, 0.1.0)
ERROR: No matching distribution found for tf-keras-vis==0.2.2
@keisen
Copy link
Owner

keisen commented May 7, 2020

Thank you for your reporting.
I'll deal with this issue when TF supported Python 3.8+.

https://www.tensorflow.org/install#install-tensorflow-2

@keisen keisen added enhancement New feature or request pending labels May 7, 2020
@keisen keisen self-assigned this May 7, 2020
@keisen keisen removed the enhancement New feature or request label May 7, 2020
@bersbersbers
Copy link
Author

bersbersbers commented May 7, 2020

@keisen
Copy link
Owner

keisen commented May 7, 2020

Thank you for letting me know! I'll deal with it in PR/#7.

@keisen keisen added enhancement New feature or request and removed pending labels May 7, 2020
@keisen keisen mentioned this issue May 7, 2020
@keisen keisen closed this as completed in #7 May 8, 2020
@bersbersbers
Copy link
Author

> pip install tf-keras-vis==0.2.4
ERROR: Could not find a version that satisfies the requirement tf-keras-vis==0.2.4 (from versions: 0.0.1, 0.1.0)
ERROR: No matching distribution found for tf-keras-vis==0.2.4

PyPI says Requires: Python >=3.5, <=3.8 - could it be that that excludes Python 3.8.2?

@keisen
Copy link
Owner

keisen commented May 8, 2020

Thank you for letting me know that! I didn't realize it.
For now, I applied a patch to setup.py and uploaded v0.2.5 to PyPI.
Could you please try it again.

@bersbersbers
Copy link
Author

bersbersbers commented May 8, 2020

Successfully installed tf-keras-vis-0.2.5

Beautiful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants