Highlight @available/#available attributes

[ghost]

This adds the new (introduced in Swift 2) @available and #available attributes to the swift syntax file.

I chose to add this to the new swiftConditionalAttribute (since it's a conditional attribute that is used in if/guard statements) rather than the existing swiftAttributes (which are typically used to apply to functions/classes).

If you think that's wrong, I can easily update this.

Resolves #54

[aclissold]

I think that the text within the parenthesis should be un-highlighted. @available(iOS 9.0, *) looks kinda weird because 9.0 isn't really a numeric literal, and * isn't really an operator. Do you agree?

[ghost]

@aclissold I do, however, Xcode highlights the 9.0.

I wonder if you can un-highlight inside the brackets. I'm not too familiar with vim syntax highlighting.

EDIT: I should also mention that I override some of the syntax defaults of this plugin, one of which is to link the Operator with Normal (as it should be 😛), so it looks the same for me as it does in Xcode.

[aclissold]

Oh! Well if that's how Xcode does it… :P

As for swiftConditionalAttribute, hmm… reading the book, I guess it's not technically an attribute, because attributes "provide more information about a declaration or type," but #available is only used as a condition like guard let #available. The book calls it an "availability condition." Maybe something like swiftCondition or swiftConditionStatement?

And, maybe swiftPreprocessor should be renamed to swiftBuildConfiguration or swiftBuildConfigurationStatement?

And and, it looks like the line control statement #line is missing too—I had no idea that one existed!

[ghost]

Yep, I agree with your comments, I'll pick swiftConditionStatement for it then. 😄

About #line -- neither did I. I won't change the preprocessor stuff in this PR as it's not related to #54 but feel free to add a new ticket and I can pick it up or a PR if you want to add this in.

[ghost]

@aclissold,

Thoughts on the newest commit?

I highlight the platforms, but skip highlighting the numbers and the *

Better now 😉?

Here's what it looks like with the latest commit (left is Vim, right is Xcode):

[ghost]

Latest commit adds some niceties to @available like the attribute arguments for available.

(Boy this is more work for @available than I thought I would do 😛 but since @available is pretty useful, might be worth having this)

[aclissold]

When I saw this issue a while ago, I thought about simply adding #available to the list of keywords, but then I thought about all this stuff for @available and how little I know about Vim highlighting, so thanks for stepping up to the plate :P

I like the stuff in the screenshot you posted buuuuuuuut I don't know how I feel about highlighting all the stuff in @available. It seems weird to me, Xcode doesn't do it, and it's especially jarring with my colorscheme lol:

[keith]

Would it be reasonable to group this in the "swiftPreprocessor" group?

[ghost]

Yeah I thought about that, but it's not really a pre-processor is it?

But if you're fine with it, I can make that change.

[keith]

¯\_(ツ)_/¯ I'm fine with it either way. Maybe we could generalize that group since preprocessor is a misnomer anyways.

[ghost]

Well the Swift book calls them a BuildConfigurationStatement, which #available still isn't.

We could call it HashtagStatements or something :P.

Any thoughts on what we could call the group?

[keith]

Meh, leaving it like this is fine.

[ghost]

@aclissold: Oh! Well if Xcode doesn't do it 😛

Changed to remove the highlighting. 😄

I kept the highlight group still, so if anyone else wants, they could still get override the highlighting.

[keith]

@ajh17 re operator highlighting, feel free to submit a PR to not highlight them, although keeping the groups might be useful in the future.

[keith]

Thanks guys!