Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisations #18

Closed
10 tasks done
keithamoss opened this issue Dec 13, 2018 · 0 comments
Closed
10 tasks done

Optimisations #18

keithamoss opened this issue Dec 13, 2018 · 0 comments
Milestone

Comments

@keithamoss
Copy link
Owner

keithamoss commented Dec 13, 2018

  • Use a shouldComponentUpdate OR a tweet selector on UserReviewQueueViewContainer and TweetColumnContainer so that they only update when the assignments/column change (which hold the ids of the tweets), not when any tweet object changes
  • Ensure heavy parts of the UI (e.g. triage view) only update when absolutely necessary
  • Reduce what gets passed down to TweetColumn as much as possible (e.g. Does it actually need the details of assignments or just that there's a tweet_assignment?
  • Take a quick pass over TweetColumn and look for performance improvements
  • Does switching to queue and back to columns maintain scroll position in each column?
  • How does triage actually know when new tweets are being added above your position in the list?
  • Can we intelligently discard tweets for users not doing triage (i.e. They only need to have tweets stored locally that are assigned to them or that are enough to load TweetColumn)
  • Maybe we don't need to send users new tweets and store them unless they're on triage view and the tweets are within X of their current view?
  • Maybe we can only send tweet data if it's part of an assignment. For triage just send a new tweet total.
  • Does loadMoreRows work for future tweets (scrolling up)? How does it now that tweets are being added at the top and not elsewhere?
@keithamoss keithamoss mentioned this issue Dec 17, 2018
23 tasks
@keithamoss keithamoss added this to the Alpha Testing milestone Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant