Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show placeholder tweets if we don't have the tweet data client-side yet #43

Open
keithamoss opened this issue Dec 20, 2018 · 0 comments

Comments

@keithamoss
Copy link
Owner

Right now we rely entirely on loadMoreRows from react-virtualized to handle loading tweets. React-Virtualized has the option to show "placeholders" - for example, as the user is scrolling or as loadMoreRows is loading data. As we move towards issues like #26 we'll need to potentially sync a large number of tweets in.

Let's investigate this further and see how we can use it to improve the UX of seeing at least something for the tweet placeholders rather than blank spaces.We could avoid the need to have all tweet objects client-side if we instead showed placeholder tweets in the columns as the user is scrolling (up or down), fire events up to the store, debounce/wait those events OR wait until the user stops scrolling, then fetch them as a batch, shove them into the store, and replace the placeholder tweets with the actual tweets (and recalculate the cell heights).

This would handily remove issues around having to send potentially huge payloads when the user is scrolled a long way down the column and we're trying to send them all tweets between now and their current position.

Relates to #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant