Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout #17

Closed
KeithCu opened this issue Feb 11, 2020 · 2 comments
Closed

Add timeout #17

KeithCu opened this issue Feb 11, 2020 · 2 comments

Comments

@KeithCu
Copy link
Owner

KeithCu commented Feb 11, 2020

This request hanged:
https://www.google.com/alerts/feeds/12151242449143161443/16985802477674969984

That means that anyone fetching a page will never return either.

It seems to be working again now, but it would be nice to have some socket timeout logic of 5 seconds or so max.

Also, I could have some logic to temporarily cache an empty feedparser result so that anyone who was waiting could just use that value and not block the whole site.

@KeithCu
Copy link
Owner Author

KeithCu commented Feb 11, 2020

Added a 5 second timeout value. Let's see how it works over time.

@KeithCu
Copy link
Owner Author

KeithCu commented Feb 11, 2020

I've tested it and it will now just return an empty result set and not block the whole site for minutes.

@KeithCu KeithCu closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant