Promises

[benjamingr]

Given they're in the language standard now, it would probably be the better idea to use them or at least support them - especially since people want to use async/await or generator coroutines in new code.

[keithwhor]

Definitely considering what working with Promises would look like in Nodal, and appreciate the feedback. :)

[benjamingr]

Well mostly,

• controller methods can return promises (which are resolved and returned as json or rejected as errors).
• API methods (orm for instance) return promises instead of taking callbacks.

[davej]

+1, particularly on the promise interface for the ORM. You can still expose the end method for backwards compatibility if desired.

[benjamingr]

Or do like mongoose and return a promise if and only if no callback is passed

[chrisenytc]

👍

[erf]

+1 couldn't the controller routes be generator functions like in KOA ?

[keithwhor]

Closing right now; no intention to use promises in short-term future. Will re-approach in time.

[arcseldon]

+1 for promises support.

[christophehurpeau]

+1 for promises support.

[tilap]

+1 for promises support.

[ncksllvn]

I used Bluebird's promisifyAll as a quick way to add promise support.

models/overrides.js

  var Promise = require('bluebird')
  var Nodal = require('nodal')
  var Composer = require('nodal/core/required/composer')

  Promise.promisifyAll(Nodal.Model)
  Promise.promisifyAll(Nodal.Model.prototype)
  Promise.promisifyAll(Composer.prototype)

controllers/dogs_controller.js

show(){
    Dog.
        findAsync( this.params.route.id ).
        then(dog => this.respond(dog)).
        catch(err => this.respond(err))
}

Hope this helps!!

[sylvainlap]

+1 for promises support.