Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version of pysubs2 (add-on crashes on systems with Python 3.8 or higher) #11

Open
IllDepence opened this issue Jun 17, 2023 · 0 comments

Comments

@IllDepence
Copy link

On systems with Python 3.8 or higher the add-on crashes because the version of pysubs2 shipped with the add-on

  1. tries to import MutableSequence from collections instead of collections.abc (pysubs2/ssafile.py, line 1)
  2. tries to compile a regex with inline global modifiers not positioned at the start of the pattern (pysubs2/mpl2.py, line 9)

Both of these have been fixed in pysubs2 (here and here) since 2021. Going by these commits, the oldest version fixing the problem appears to be 1.3.0, but I guess it wouldn’t hurt to simply ship the most recent version (currently 1.6.1) with the add-on.

Hot fix for anyone with the same problem: I’m on Anki version ⁨2.1.62 (77dd1dc1)⁩ with Python 3.11.2 Qt 6.5.0 PyQt 6.5.0 and manually adjusting above two lines in the pysubs2 code fixed the crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant